Migrate student task list#474
Conversation
Convert student-task-list.coffee to student-task-list.component.ts Convert student-task-list.tpl.html to student-task-list.component.html Convert student-task-list.scss to student-task-list.component.scss Add student-task-list.component.css for proper styling Update Angular module imports and declarations Update AngularJS module with downgrade directive Update dashboard template to use Angular property bindings Remove old CoffeeScript files Fix filtering and sorting logic Handle taskData gracefully when not provided All original functionality preserved Fixes thoth-tech#472
- Add proper CSS hover styles for task items - Fix taskData initialization in setSelectedTask - Remove debug console logs - Ensure click events work correctly - Add pointer-events management for badges
millyamolo
force-pushed
the
migrate/student-task-list
branch
3 times, most recently
from
21c1bcf to
af0462e
Compare
millyamolo
force-pushed
the
migrate/student-task-list
branch
from
1d6ad6a to
e58eb6b
Compare
WaelAlahamdi
left a comment
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi Millicent, thanks for your effort.
The PR has been reviewed and tested locally. It meets the task requirements and no issues were found. Everything looks good.
Approved
Thirus224849242
left a comment
Thirus224849242
left a comment
There was a problem hiding this comment.
Hi Millicent, The migration appears clean in general, CoffeeScript has been removed, Angular components system has been configured correctly, the downgrade bridge wired up properly. Good Job.
Approved.
davidngash98
left a comment
davidngash98
left a comment
There was a problem hiding this comment.
Looks great! The migration is clean and faithful to the original filtering, sorting, task selection, hover and selected highlighting, the create-portfolio item, and the deselect-on-reclick behaviour all work as expected. Styles load correctly, the search input filters in real time, and the old CoffeeScript files are properly removed with no leftovers. Nice work on the migration!
sheshankarvapally
left a comment
sheshankarvapally
left a comment
There was a problem hiding this comment.
Reviewed and tested locally on the review/pr-474 branch.
Verified that the migrated student task list renders and functions correctly on the dashboard. Task items load as expected, task interactions work correctly, and the dashboard UI appears stable after the Angular/TypeScript migration. No runtime or console errors related to the migration were observed during testing.
Changes appear clean and limited to the intended student task list migration scope.
6 participants
Description
This PR migrates the student-task-list component from CoffeeScript/AngularJS to TypeScript/Angular following the frontend migration guide. This modernizes the codebase while maintaining all existing functionality.
Fixes # (issue)
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
The migration has been tested by accessing the student dashboard and verifying all component functionality works as expected. The task list displays, search filtering functions correctly, task selection works, and create portfolio items appear appropriately.
Testing Checklist:
Tested in latest Chrome
Tested in latest Safari
Tested in latest Firefox
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings