Migrate Students List Component by WaelAlahamdi · Pull Request #478 · thoth-tech/doubtfire-web

WaelAlahamdi · 2026-04-28T12:29:59Z

Description

This PR migrates the legacy students-list view from AngularJS/CoffeeScript to Angular.

Changes included

Removed legacy files:
- students-list.coffee
- students-list.tpl.html
- students-list.scss
Added Angular component files:
- students-list.component.ts
- students-list.component.html
- students-list.component.scss
Updated Angular module registration and state configuration
Removed legacy state references

Existing functionality retained

Student search and autocomplete
Advanced filters
Sorting
Pagination
CSV export
Enrol student modal
Navigation to student profile/dashboard

UI updates

Updated task progress indicators to improve visibility of student progress:

Green → completed tasks
Red → failed tasks
Grey → remaining tasks

This keeps the original behaviour while improving readability.

Fixes # (ticket number)

Type of Change

Refactor
UI improvement
Breaking change
Documentation update

Testing

Tested locally on 10.0.x

Verified:

Search functionality
Filtering
Sorting
Pagination
CSV export
Enrol modal
Student navigation
Progress bar display

Before screenshots

After screenshots

Testing Checklist

Tested in Microsoft Edge
Tested in Chrome
Tested in Safari
Tested in Firefox

Checklist

Self-reviewed
Existing functionality verified
No unrelated files included
Ready for review

…btfire-lms#1132) * refactor: confirm recursive fix and resubmit for dependent tasks * refactor: move logic to task model

Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-sanitize dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…re-lms#1138) * feat: pause feedback threshold during teaching period breaks * chore: round down days

- this may be due to the breaks re-calculated client-side

Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.13. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…pm_and_yarn/brace-expansion-1.1.13 build(deps-dev): bump brace-expansion from 1.1.11 to 1.1.13

…pm_and_yarn/node-forge-1.4.0 build(deps-dev): bump node-forge from 1.3.3 to 1.4.0

…pm_and_yarn/angular-sanitize-1.8.3 build(deps): bump angular-sanitize from 1.5.11 to 1.8.3

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.18.1) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.18.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [axios](https://github.com/axios/axios) from 1.13.6 to 1.15.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.13.6...v1.15.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.15.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…pm_and_yarn/axios-1.15.0 build(deps-dev): bump axios from 1.13.6 to 1.15.0

…-card-reword refactor: change wording to submissions waiting for discussion

…tus-buttons refactor: add colors to status action buttons

…s-have-valid-unit-role feat: confirmation modal to reassign tutorials when removing staff

Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.2 to 2.8.1. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@v2.6.2...v2.8.1) --- updated-dependencies: - dependency-name: tslib dependency-version: 2.8.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.38 to 8.5.10. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.38...8.5.10) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.10 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

* feat: enable comment editing * chore: fix styling * chore: place cursor at the end of text

Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.2 to 2.8.1. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@v2.6.2...v2.8.1) --- updated-dependencies: - dependency-name: tslib dependency-version: 2.8.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…pm_and_yarn/postcss-8.5.10 build(deps-dev): bump postcss from 8.4.38 to 8.5.10

…pm_and_yarn/jquery-3.5.0 build(deps): bump jquery from 2.1.4 to 3.5.0

Bumps [jquery](https://github.com/jquery/jquery) from 3.5.0 to 4.0.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Changelog](https://github.com/jquery/jquery/blob/main/changelog.md) - [Commits](jquery/jquery@3.5.0...4.0.0) --- updated-dependencies: - dependency-name: jquery dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.8.3. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.2.5...3.8.3) --- updated-dependencies: - dependency-name: prettier dependency-version: 3.8.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…pm_and_yarn/prettier-3.8.3 build(deps-dev): bump prettier from 3.2.5 to 3.8.3

…pm_and_yarn/jquery-4.0.0 build(deps): bump jquery from 3.5.0 to 4.0.0

owens-hub-git

Overall this looks ok, some things I wanted to ask about:

I like the newer style, but I think the blue outline from before was fine and allowed some visual positives where you can see the bounds of the component
Are you considering the mobile views? I know most people won't be using it in that way but it shows a weird visual where it's off the screen, shown below:

)

millyamolo

I tested the PR locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved

millyamolo

I tested the PR#478 locally and verified the migrated students-list component works as expected.
The new Angular/TypeScript implementation appears consistent with the existing app structure.
I did not find any regressions in the students list behavior during local testing.
The migration looks complete and ready to merge from my side. Approved

WaelAlahamdi · 2026-05-06T11:17:48Z

Overall this looks ok, some things I wanted to ask about:

I like the newer style, but I think the blue outline from before was fine and allowed some visual positives where you can see the bounds of the component

Are you considering the mobile views? I know most people won't be using it in that way but it shows a weird visual where it's off the screen, shown below:

Thanks @owens-hub-git, I’ve addressed the mobile layout issue and restored the visual boundary styling. The component has been re-tested on both desktop and mobile views.

owens-hub-git

I will approve here as it looks fine visually, I am concerned with the validity of the ts file that goes with it by the complexity difference between the original design

b0ink and others added 30 commits March 24, 2026 12:39

refactor: confirm recursive fix and resubmit for dependent tasks (dou…

45e6141

…btfire-lms#1132) * refactor: confirm recursive fix and resubmit for dependent tasks * refactor: move logic to task model

chore(release): 10.0.1-23

04f4d30

feat: confirm recursive fix in mobile tutor view

b64601a

chore(release): 10.0.1-24

f50a58e

feat: display sso redirecting state

248c992

feat: pause feedback threshold during teaching period breaks (doubtfi…

12fbf81

…re-lms#1138) * feat: pause feedback threshold during teaching period breaks * chore: round down days

chore: ensure tasks not in overflow are filtered out

01a407e

- this may be due to the breaks re-calculated client-side

chore(release): 10.0.1-25

5eb855f

chore: display days since submission in tooltip

a9bd5c6

chore(release): 10.0.1-26

6d283c8

refactor: add colors to status action buttons

da2de98

refactor: show status colors only on mouse hover

e5e4047

refactor: use material icons for recommended status button

87c5c6f

Merge pull request doubtfire-lms#1144 from doubtfire-lms/dependabot/n…

7d62d3d

…pm_and_yarn/brace-expansion-1.1.13 build(deps-dev): bump brace-expansion from 1.1.11 to 1.1.13

Merge pull request doubtfire-lms#1142 from doubtfire-lms/dependabot/n…

361b989

…pm_and_yarn/node-forge-1.4.0 build(deps-dev): bump node-forge from 1.3.3 to 1.4.0

Merge pull request doubtfire-lms#1133 from doubtfire-lms/dependabot/n…

113b9a2

…pm_and_yarn/angular-sanitize-1.8.3 build(deps): bump angular-sanitize from 1.5.11 to 1.8.3

refactor: change wording to submissions waiting for discussion

a68d757

Merge pull request doubtfire-lms#1159 from doubtfire-lms/dependabot/n…

7e362e9

…pm_and_yarn/axios-1.15.0 build(deps-dev): bump axios from 1.13.6 to 1.15.0

Merge pull request doubtfire-lms#1155 from b0ink/refactor/discuss-due…

f7bbdf3

…-card-reword refactor: change wording to submissions waiting for discussion

Merge pull request doubtfire-lms#1146 from b0ink/refactor/colored-sta…

c5f9181

…tus-buttons refactor: add colors to status action buttons

feat: confirmation modal to reassign tutorials when removing staff

5f90e90

Merge pull request doubtfire-lms#1162 from b0ink/feat/ensure-tutorial…

dce9e94

…s-have-valid-unit-role feat: confirmation modal to reassign tutorials when removing staff

chore(release): 10.0.27

0ba137e

chore(release): 10.0.1-27

b885208

chore: revert package upgrade

f35d19d

b0ink and others added 19 commits April 22, 2026 13:08

chore: clear overseer step cache

d938712

fix: open report in turnitin

091aaf8

chore(release): 10.0.1-33

01b5b2f

chore: increase scrolling attempt to find comparison

e9f7e39

chore(release): 10.0.1-34

b7939fa

fix: task route transition race when switching from inbox

63c52dc

feat: bulk import staff via emails (doubtfire-lms#1195)

c91ab47

feat: edit comments (doubtfire-lms#1194)

976b6ac

* feat: enable comment editing * chore: fix styling * chore: place cursor at the end of text

chore(release): 10.0.1-35

82fe3ed

Merge pull request doubtfire-lms#1192 from doubtfire-lms/dependabot/n…

ce20305

…pm_and_yarn/postcss-8.5.10 build(deps-dev): bump postcss from 8.4.38 to 8.5.10

Merge pull request doubtfire-lms#1163 from doubtfire-lms/dependabot/n…

2570b9f

…pm_and_yarn/jquery-3.5.0 build(deps): bump jquery from 2.1.4 to 3.5.0

Merge pull request doubtfire-lms#1180 from doubtfire-lms/dependabot/n…

2e6f49e

…pm_and_yarn/prettier-3.8.3 build(deps-dev): bump prettier from 3.2.5 to 3.8.3

Merge pull request doubtfire-lms#1172 from doubtfire-lms/dependabot/n…

0f627ac

…pm_and_yarn/jquery-4.0.0 build(deps): bump jquery from 3.5.0 to 4.0.0

chore: remove client side code to check for feedback

5114f18

owens-hub-git approved these changes May 3, 2026

View reviewed changes

anaghwadhwa123 approved these changes May 4, 2026

View reviewed changes

b0ink added 2 commits May 4, 2026 16:40

chore: remove client side code to check for feedback (doubtfire-lms#1211

6727a59

)

chore(release): 10.0.1-36

1ff046b

millyamolo approved these changes May 5, 2026

View reviewed changes

owens-hub-git approved these changes May 6, 2026

View reviewed changes

WaelAlahamdi added 2 commits May 10, 2026 11:58

refactor: migrate students list component to angular

fa144b3

fix: improve students list mobile layout

ba58972

WaelAlahamdi force-pushed the migrate-students-list branch from ce6fa8d to ba58972 Compare May 10, 2026 02:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Students List Component#478

Migrate Students List Component#478
WaelAlahamdi wants to merge 78 commits into
thoth-tech:10.0.xfrom
WaelAlahamdi:migrate-students-list

WaelAlahamdi commented Apr 28, 2026

Uh oh!

owens-hub-git left a comment

Uh oh!

millyamolo left a comment

Uh oh!

millyamolo left a comment

Uh oh!

WaelAlahamdi commented May 6, 2026

Uh oh!

owens-hub-git left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

WaelAlahamdi commented Apr 28, 2026

Description

Changes included

Existing functionality retained

UI updates

Type of Change

Testing

Testing Checklist

Checklist

Uh oh!

owens-hub-git left a comment

Choose a reason for hiding this comment

Uh oh!

millyamolo left a comment

Choose a reason for hiding this comment

Uh oh!

millyamolo left a comment

Choose a reason for hiding this comment

Uh oh!

WaelAlahamdi commented May 6, 2026

Uh oh!

owens-hub-git left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants