refactor: migrating groups.coffee to angular#486
Conversation
sakethsram8888
left a comment
There was a problem hiding this comment.
Reviewed and tested this locally in my dev container, the groups page renders correctly, "No Groupwork Enabled" state loads up fine with the Material icon and Unit Administration button showing as expected. No errors or issues on my end.
The migration is clean and well-scoped. The Angular control flow (@if/@else), Material icon swap, Tailwind replacements, and the hybrid downgrade registration are all done correctly. The old AngularJS controller and groups.tpl.html cleanup is exactly what we want to see for this kind of migration.
One minor thing, might be worth dropping a quick comment in the empty groups.component.scss just to make it clear the lack of styles is intentional.
Overall code is clean and error-free. can be approved from my end
sheshankarvapally
left a comment
There was a problem hiding this comment.
Reviewed and tested locally on the review/pr-486 branch.
Verified that the migrated units/states/groups flow loads correctly and the Groups List page renders successfully with the expected empty state (No Group Work). Navigation, UI rendering, and styling all appear to work as expected with no visible issues or console errors during testing.
Changes also look clean and limited to the intended Angular migration scope for the groups state/components.
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Hi Sujay, thanks for your work.
Tested locally and the groups page loads correctly with no console issues. The migration scope looks clean and correct.
One small note: groups.component.scss is empty, please just confirm that no additional custom styling is required for this page.
Approved.
|
Hi Wael, thanks for the review and approval! |
Description
Migrates
units/states/groupsfrom CoffeeScript/AngularJS to TypeScript/Angularas part of the ongoing Angular migration effort.
Changes
groups.component.tswith@Input()bindings forunitandunitRolegroups.component.htmlreplacing oldgroups.tpl.html:ng-if/ng-hidewith Angular@if/@elsecontrol flowfa-usersicon with Angular Materialmat-iconui-srefwith Angular[uiSref]bindinggroups.component.scss(no custom styles needed)UnitGroupsStateComponentindoubtfire-angular.module.tsdoubtfire-angularjs.module.tsfor hybrid compatibilitygroups.coffeegroups.tpl.htmlTesting
units/1/students/groupsas a Convenordescription text, and Unit Administration button
Screenshots