fix(upload-submission-modal): resolve upgraded modal dependency issue

[sheshankarvapally]

Summary

Investigated and updated the upload-submission-modal dependency flow as part of the Angular 17 migration work.

What Happened

This ticket originally involved three files:

• upload-submission-modal.coffee
• upload-submission-modal.scss
• upload-submission-modal.tpl.html

During investigation, the modal dependency was identified in the CoffeeScript file where the upload submission modal was opened using the legacy AngularJS modal service.

The initial migration updated the modal service usage from $modal to $uibModal.

After testing locally, a runtime Angular 17 dependency injection issue appeared:

• Circular dependency in DI detected for InjectionToken uploadSubmissionModal

Further investigation showed that the issue was coming from task-submission-card.component.ts, where uploadSubmissionModal was being injected into the Angular component but was not actually used.

Changes Made

• Updated the upload submission modal dependency path.
• Investigated nested component usage inside the modal template.
• Traced the upgraded AngularJS provider through ajs-upgraded-providers.ts.
• Removed the unused uploadSubmissionModal injection from task-submission-card.component.ts.
• Removed the unused uploadSubmissionModal import.
• Kept the existing upload submission workflow unchanged.

Files Changed

• src/app/tasks/modals/upload-submission-modal/upload-submission-modal.coffee
• src/app/projects/states/dashboard/directives/task-dashboard/directives/task-submission-card/task-submission-card.component.ts

Verification

• Confirmed the web app builds successfully.
• Confirmed the page loads without the previous Angular 17 circular dependency console error.
• Confirmed the task submission card no longer directly injects the upgraded modal provider unnecessarily.
• Confirmed unrelated JPlag-Report-Viewer changes were not included in the commit.

Notes

The template and SCSS files were reviewed but did not require changes because the issue was related to dependency injection, not UI structure or styling.

[sheshankarvapally]

Additional investigation identified an Angular 17 circular dependency linked to the upgraded uploadSubmissionModal provider. The unused injection in task-submission-card.component.ts was removed to resolve the runtime DI issue while preserving the existing submission workflow.

[Sujay-Deakin]

Confirmed that the circular dependency error is resolved. correctly removes the hanging injection and import, migration looks clean. The app builds successfully with no console errors, the upload submission workflow remains functionally unchanged. LGTM

[millyamolo]

Tested locally on pr-487.
• Upload/submission modal opens correctly and the upload workflow completes as expected.
• No console errors related to the modal dependency ($uibModalProvider / uploadSubmissionModal DI) observed during testing. Looks good to approve

[sakethsram8888]

Reviewed and tested locally.
Confirmed the circular dependency error is resolved the unused uploadSubmissionModal injection and import are correctly removed from task-submission-card.component.ts, and the modal to uibModal update in the CoffeeScript file looks good. Upload submission workflow still works as expected.