Skip to content

Migrate/util service#491

Open
sakethsram8888 wants to merge 2 commits into
thoth-tech:10.0.xfrom
sakethsram8888:migrate/utilService
Open

Migrate/util service#491
sakethsram8888 wants to merge 2 commits into
thoth-tech:10.0.xfrom
sakethsram8888:migrate/utilService

Conversation

@sakethsram8888
Copy link
Copy Markdown

Description
Migrates the utilService module from CoffeeScript (AngularJS) to TypeScript (Angular 17).

The file utilService.coffee has been rewritten as utilService.ts, converting the AngularJS
module definition to TypeScript while preserving all existing filters (fromNow, titleize, humanize)
and the autoFillSync directive.

The import in doubtfire-angularjs.module.ts has been updated to reference the new TypeScript
file directly instead of the compiled JavaScript build output.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?
The application was tested locally at localhost:4200. The app loads correctly and login
functionality works as expected with the new TypeScript file in place of the old CoffeeScript file.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Copy Markdown

@sheshankarvapally sheshankarvapally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally on the review/pr-491 branch.

Verified that the application builds and runs successfully with the migrated utilService.ts implementation. Login, dashboard loading, task list display, and general navigation work as expected with no visible UI issues or console errors during testing.

Changes appear clean and limited to the intended utilService migration scope.

Copy link
Copy Markdown

@Sujay-Deakin Sujay-Deakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally
Verified the app builds and runs successfully with the migrated utilService.ts. The filters (fromNow, titleize, humanize) and autoFillSync directive all appear to work correctly, with no console errors during testing.
Changes are clean and scoped to the intended utilService migration.
Approved.

Copy link
Copy Markdown

@millyamolo millyamolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally the PR locally and the app loads and login works with the new TypeScript utilService. Approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants