Migrate/util service#491
Conversation
sheshankarvapally
left a comment
There was a problem hiding this comment.
Reviewed and tested locally on the review/pr-491 branch.
Verified that the application builds and runs successfully with the migrated utilService.ts implementation. Login, dashboard loading, task list display, and general navigation work as expected with no visible UI issues or console errors during testing.
Changes appear clean and limited to the intended utilService migration scope.
Sujay-Deakin
left a comment
There was a problem hiding this comment.
Reviewed and tested locally
Verified the app builds and runs successfully with the migrated utilService.ts. The filters (fromNow, titleize, humanize) and autoFillSync directive all appear to work correctly, with no console errors during testing.
Changes are clean and scoped to the intended utilService migration.
Approved.
millyamolo
left a comment
There was a problem hiding this comment.
Tested locally the PR locally and the app loads and login works with the new TypeScript utilService. Approve.
Description
Migrates the utilService module from CoffeeScript (AngularJS) to TypeScript (Angular 17).
The file
utilService.coffeehas been rewritten asutilService.ts, converting the AngularJSmodule definition to TypeScript while preserving all existing filters (fromNow, titleize, humanize)
and the autoFillSync directive.
The import in
doubtfire-angularjs.module.tshas been updated to reference the new TypeScriptfile directly instead of the compiled JavaScript build output.
Type of change
How Has This Been Tested?
The application was tested locally at localhost:4200. The app loads correctly and login
functionality works as expected with the new TypeScript file in place of the old CoffeeScript file.
Testing Checklist:
Checklist: