Migrate/units states tasks definition#495
Conversation
…btfire-lms#1132) * refactor: confirm recursive fix and resubmit for dependent tasks * refactor: move logic to task model
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-sanitize dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…re-lms#1138) * feat: pause feedback threshold during teaching period breaks * chore: round down days
- this may be due to the breaks re-calculated client-side
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.3 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.3...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.13. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…pm_and_yarn/brace-expansion-1.1.13 build(deps-dev): bump brace-expansion from 1.1.11 to 1.1.13
…pm_and_yarn/node-forge-1.4.0 build(deps-dev): bump node-forge from 1.3.3 to 1.4.0
…pm_and_yarn/angular-sanitize-1.8.3 build(deps): bump angular-sanitize from 1.5.11 to 1.8.3
sheshankarvapally
left a comment
sheshankarvapally
left a comment
There was a problem hiding this comment.
Approved from my side.
I tested PR #495 locally on the pr-495 branch. The migrated units/states/tasks/definition flow loads correctly, task details render as expected, the task list remains functional, and navigation between tasks works properly.
I have attached a console screenshot for transparency. It only shows a non-blocking browser accessibility warning related to aria-hidden focus handling, and it does not affect the migrated task definition functionality. Overall, the PR looks good to me.
sakethsram8888
left a comment
sakethsram8888
left a comment
There was a problem hiding this comment.
Reviewed and tested locally.
Verified the Task Explorer loads correctly with the migrated definition.component.ts task list renders with all 17 tasks, student submissions and comments panel display as expected, and filtering by task definition works correctly. No console errors during testing.
Changes are clean and scoped to the intended definition migration.
happy to Approve.
4 participants
Description
Migrates
units/states/tasks/definition/definition.coffeefrom CoffeeScript/AngularJS to TypeScript/Angular as part of the ongoing Angular migration effort.Changes
definition.component.tswithTaskDefinitionStateComponentdefinition.component.htmlwith<ui-view>as the router outletdefinition.component.scss(no custom styles needed)TaskDefinitionStateComponentindoubtfire-angular.module.tsdoubtfire.units.states.tasks.definitionmodule with state config andTaskDefinitionStateCtrlcontroller indoubtfire-angularjs.module.tsfor hybrid compatibilityimport 'build/src/app/units/states/tasks/definition/definition.js'fromdoubtfire-angularjs.module.tsdefinition.coffeeTesting
Screenshots
Note: This PR is based on the latest upstream 10.0.x. Some additional files appear in the diff due to upstream commits not yet merged into thoth-tech:10.0.x. Only the definition migration changes are part of this PR (visible in commit 21c0d797).