Conversation
Closes #1327. This commit fixes two problems. First, it improve the developer experience by changing the [subscription adapter][sa] from `async` to `redis`. Doing this accounts for the following pain point: > The async adapter only works within the same process, so for manually triggering cable updates from a console and seeing results in the browser, you must do so from the web console (running inside the dev process), not a terminal started via `bin/rails console`! Add `console` to any action or any ERB template view to make the web console appear. Next, we update the [Redis adapter][ra] in `production` to account for Heroku's [requirements][req]. We don't need to uncomment the Redis related lines in `.github/workflows/ci.yml` since we're not using Redis in our `test` environment. [sa]: https://guides.rubyonrails.org/action_cable_overview.html#subscription-adapter [ra]: https://guides.rubyonrails.org/action_cable_overview.html#redis-adapter [req]: https://devcenter.heroku.com/articles/connecting-heroku-redis#connecting-in-rails
stevepolitodesign
force-pushed
the
sp-configure-action-cable
branch
from
46cddb0 to
91093bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1327.
This commit fixes two problems.
First, it improves the developer experience by changing the subscription
adapter from
asynctoredis. Doing this accounts for thefollowing pain point:
Next, we update the Redis adapter in
productionto account forHeroku's requirements.
We don't need to uncomment the Redis related lines in
.github/workflows/ci.ymlsince we're not using Redis in ourtestenvironment.