nlog: add disk-pressure-aware retention to fix #721#1139
Open
SBALAVIGNESH123 wants to merge 1 commit intotimeplus-io:developfrom
Open
nlog: add disk-pressure-aware retention to fix #721#1139SBALAVIGNESH123 wants to merge 1 commit intotimeplus-io:developfrom
SBALAVIGNESH123 wants to merge 1 commit intotimeplus-io:developfrom
Conversation
0f6e526 to
ab382cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #721
When disk usage reaches 90%, the existing retention policy doesn't kick in because the
min_size_to_keepguard (default 4GB) blocks deletion — even if the disk is nearly full, individual logs smaller than 4GB won't have their segments cleaned up. This means retention only works based on per-log size and time thresholds, but never considers actual disk space.This PR adds a fourth deletion strategy, deleteDiskPressureBreachedSegments, that activates only when disk usage exceeds a configurable threshold (default 90%). When triggered, it bypasses the
min_size_to_keepguard and deletes the oldest segments to free disk space. The active segment is always preserved by the existing deletableSegments() mechanism. When disk usage is below the threshold, behavior is completely unchanged.Changes:
disk_usage_threshold_percent(default 90%) with validation and debug outputdisk_pressureflag is truestd::filesystem::space()check on each root directory in cleanupLogs() to detect disk pressure