add user table

[joachimschmidt557]

this is a first step toward saving other user-related data in the database (e.g. keys)

[Copilot]

Pull request overview

Adds a new user table and backfills it from existing interval data, then rebuilds the interval table to add a foreign-key relationship as a foundation for storing additional user-related data (e.g., keys) in the DB.

Changes:

• Introduce a user table keyed by user_id and seed it from distinct interval.user_id values.
• Recreate interval as a new table with a FOREIGN KEY (user_id) REFERENCES user(user_id) ON DELETE CASCADE, then swap it in.
• Provide a down migration that rebuilds interval without the FK and drops the user table.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
storage/migrations/20260417200302_add_user_table.up.sql	Creates and seeds user, rebuilds interval to add FK + cascade semantics.
storage/migrations/20260417200302_add_user_table.down.sql	Restores interval schema without FK and removes the user table.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Other migrations in this repo use IF NOT EXISTS / IF EXISTS for CREATE/DROP. To keep migrations resilient to partial runs and consistent with existing style, consider using CREATE TABLE IF NOT EXISTS user and DROP TABLE IF EXISTS ... (including temp tables like new_interval/old_interval if you keep them).

[Copilot]

For consistency with existing migrations (e.g., initialize.down.sql uses DROP TABLE IF EXISTS), consider using DROP TABLE IF EXISTS user here. This also makes rollback safer if the table was already removed or the migration was partially applied.

Suggested change

	DROP TABLE user;
	DROP TABLE IF EXISTS user;

[Copilot]

AUTOINCREMENT is usually unnecessary in SQLite and can have downsides (forces monotonically increasing ids and prevents reuse, can increase sqlite_sequence churn). If you don’t need those semantics, prefer INTEGER PRIMARY KEY without AUTOINCREMENT for the user_id column.

Suggested change

	user_id integer PRIMARY KEY AUTOINCREMENT
	user_id integer PRIMARY KEY

[Copilot]

This migration is multi-step (copy data, drop table, rename). Consider wrapping the whole sequence in a single transaction so a failure can’t leave the DB in a partially migrated state (e.g., interval dropped but new_interval not renamed).

[Copilot]

SQLite only enforces FOREIGN KEY constraints (and runs ON DELETE CASCADE) when foreign key enforcement is enabled on the connection. I couldn’t find any code enabling PRAGMA foreign_keys = ON / DSN _foreign_keys=on, so this constraint may be a no-op at runtime.