fix: use SafeCryptoMemEquals for AES-EAX tag verification#17
Open
mohammadmseet-hue wants to merge 1 commit intotink-crypto:mainfrom
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Replace hand-rolled EqualBlocks comparison with SafeCryptoMemEquals (CRYPTO_memcmp) for AEAD authentication tag verification in AES-EAX. AES-EAX was the only AEAD primitive in Tink that did not use the constant-time SafeCryptoMemEquals for tag comparison. All other AEAD and MAC implementations (AES-SIV, HMAC, AES-CMAC, etc.) already use SafeCryptoMemEquals. The hand-rolled XOR+OR pattern in EqualBlocks is not guaranteed to be constant-time by the C++ standard, as compilers may optimize it into early-exit code.
80f1199 to
a53d052
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EqualBlocksXOR+OR comparison withSafeCryptoMemEquals(wrappingCRYPTO_memcmp) for AEAD authentication tag verification in AES-EAX decryptEqualBlocksmethod fromAesEaxBoringSslSafeCryptoMemEqualsfor tag comparisonMotivation
All other AEAD and MAC implementations in Tink use
SafeCryptoMemEqualsfor authentication tag verification:aes_siv_boringssl.cc:294SafeCryptoMemEqualshmac_boringssl.cc:125SafeCryptoMemEqualsaes_cmac_boringssl.cc:173SafeCryptoMemEqualsstreaming_mac_impl.cc:189SafeCryptoMemEqualschunked_mac_impl.cc:87SafeCryptoMemEqualsaes_eax_boringssl.cc:304→EqualBlocksSafeCryptoMemEqualsThe hand-rolled XOR+OR pattern in
EqualBlocksis not guaranteed to be constant-time by the C++ standard. While current GCC on x86-64 generates constant-time SSE code, this is not guaranteed across other compilers (MSVC, Clang), architectures (ARM, RISC-V), or with LTO/PGO optimizations.CRYPTO_memcmpuses explicit barriers to prevent compiler optimizations.Test plan
AesEaxBoringSslTesttests pass (no behavioral change — both functions return the same boolean result for equal/unequal blocks)SafeCryptoMemEqualswrapsCRYPTO_memcmpwhich is the standard constant-time comparison primitive