fix overlap between full and favorite#1882
Open
hanaeatsplanes wants to merge 2 commits intotjcsl:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the search command parsing logic in
intranet/static/js/eighth/signup.search.jsto ensure more precise filtering for favorite and full activities. The changes clarify which commands trigger specific filters, reducing ambiguity and potential conflicts.Improvements to command parsing:
"fa"command prefix instead of just"f", making the favorite filter more explicit and less likely to overlap with other filters."fu"command prefix instead of just"f", ensuring that the full filter is only triggered when intended and does not conflict with the favorite filter.see: #1881