Open
Conversation
Resolves #63 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
for more information, see https://pre-commit.ci
The normalize-metadata.lua filter in inara requires affiliation to be a
string ("1") not an integer (1) to correctly look up affiliations by index.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
mdformat was reformatting paper.md, converting YAML frontmatter `---` delimiters to horizontal rules and breaking indentation, which caused normalize-metadata.lua to fail with a nil authors error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the repository for a JOSS submission by adding the draft paper + bibliography and introducing CI to build a draft PDF artifact on pushes.
Changes:
- Add
joss/paper.md(draft JOSS paper) andjoss/paper.bib(references). - Add a GitHub Actions workflow to build and upload a draft PDF on each push.
- Update pre-commit configuration to exclude the
joss/directory frommdformat.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
joss/paper.md |
Introduces the JOSS paper draft (front matter + Summary/Statement of need). |
joss/paper.bib |
Adds BibTeX entries for cited projects/publications used by the paper. |
.pre-commit-config.yaml |
Prevents mdformat from reformatting the JOSS paper directory. |
.github/workflows/ci-draft-pdf.yml |
Builds the JOSS draft PDF and uploads it as a CI artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tkoyama010
commented
Mar 11, 2026
tkoyama010
commented
Mar 12, 2026
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
- Pin actions/checkout, openjournals-draft-action, and actions/upload-artifact to full commit SHAs - Add persist-credentials: false to checkout step - Add minimal permissions block at workflow and job level Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use the official VTK citation from book.vtk.org with ISBN and canonical title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace GitHub repository reference with the Zenodo DOI citation (10.5281/zenodo.10962631) for vtk.js v30.4.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use the official Pyodide Zenodo citation (10.5281/zenodo.5156931) and update paper text to reference Pyodide instead of JupyterLite and Jupyter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace 'and others' with the full author list from the Zenodo record (10.5281/zenodo.10962631). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tkoyama010
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joss/paper.mdwith a draft paper for submission to the Journal of Open Source Softwarejoss/paper.bibwith references for PyVista, vtk.js, VTK, NumPy, JupyterLite, and Jupyter.github/workflows/ci-draft-pdf.ymlto build and upload a draft PDF on every pushResolve #63
Test plan
ci-draft-pdfworkflow builds the PDF without errorsCITATION.cff