Open
Conversation
52f7429 to
be0f431
Compare
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 109548 total, 107859 passed (pass rate: 98.5%), sqlglot version: sqlglot:vaggelisd/bump_sqlglot_mypy: 108302 total, 107140 passed (pass rate: 98.9%), sqlglot version: Transitions: ✅ 7 test(s) passed |
be0f431 to
eba3a60
Compare
georgesittas
reviewed
Apr 2, 2026
Collaborator
georgesittas
left a comment
There was a problem hiding this comment.
A couple of questions to make sure we don't break the developer experience with these changes, LGTM otherwise.
georgesittas
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mypy released 1.20 which includes our mypyc fixes but dropped Python 3.9.
This PR changes the following:
setup.py: Use vanillamypyfor linting instead ofsqlglot-mypysqlglotc/pyproject.toml: Bumpsqlglot-mypyto 1.20 and require Python >= 3.10package-publish.yml: Removecp39from mypyc wheel build matrixpackage-test.yml: Skiptestcon 3.9 (runmake style testinstead ofmake check)Mypy 1.20 changelog