feat(edgeless): add center anchor point on shapes for connectors#9172
Open
formicoidea wants to merge 2 commits intotoeverything:mainfrom
Open
feat(edgeless): add center anchor point on shapes for connectors#9172formicoidea wants to merge 2 commits intotoeverything:mainfrom
formicoidea wants to merge 2 commits intotoeverything:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@formicoidea is attempting to deploy a commit to the toeverything Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectors can originate from or target the shape center
shape-specific line intersection math. An approach where the connector does not stop at the edge of the shape would require automatic management of connectors within a layer, which is not the current design philosophy in Blocksuite. Furthermore, manually managing the z-index of connectors would be too time-consuming because it would have to be done for every new shape added.
Changes
Core logic (connector-manager.ts):
perimeter exit point, using the shape's own getLineIntersections method
Connector tool (connector-tool.ts):
eligible
Storage (edit-props-store.ts):
Playground (starter-debug-menu.ts):
Tests (connector-center-anchor.spec.ts):
endpoint validation, mixed shape types, DOM/SVG rendering
Test plan
--browser.headless — 9/9 passing