mat4: Support infinite far planes in mat4.frustum#362
Open
magcius wants to merge 1 commit intotoji:masterfrom
Open
mat4: Support infinite far planes in mat4.frustum#362magcius wants to merge 1 commit intotoji:masterfrom
magcius wants to merge 1 commit intotoji:masterfrom
Conversation
This is supported in mat4.perspective, so why not mat4.frustum?
Collaborator
|
Thanks for the PR! Mind writing a unit test for that? |
Author
|
I probably won't have time for a bit to write one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is supported in mat4.perspective, so why not mat4.frustum?