Silence clippy lints for #[instrument] on async functions for crates that warn on implicit_return#3485
Open
mjbshaw wants to merge 2 commits intotokio-rs:mainfrom
Open
Silence clippy lints for #[instrument] on async functions for crates that warn on implicit_return#3485mjbshaw wants to merge 2 commits intotokio-rs:mainfrom
mjbshaw wants to merge 2 commits intotokio-rs:mainfrom
Conversation
…hat warn on implicit_return The macro expands to a trialing if statement that is used as an implicit return value for the function. That works, but for users who set `implicit_return = "deny"` then this results in triggering clippy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro expands to a trialing if statement that is used as an implicit return value for the function. That works, but for users who set
implicit_return = "deny"then this results in triggering clippy.Motivation
See rust-lang/rust-clippy#16676
Minimum reproducible example:
Cargo.toml:
src/lib.rs:
If you then run
cargo clippyyou get this result:Solution
#[allow(clippy::implicit_return)]on the trailing return so it doesn't trigger clippy.