You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After testing it out, I'm not sure I want it to replace the Table itself in all cases. I think it would be more appropriate to have an option to specify the output format, and only in the case where --format=markdown would we use this markdown table.
Well, why? If you're missing the styled headers, those can be added. Otherwise I don't know if anyone even noticed the difference..
I suppose we could reuse SymfonyStyle, overriding its table(). That new Style class would then switch table implementations based on --format-table?
In another project I'm preparing a SymfonyStyle / OutputStyle in a base Command's initialize() and assigning it to a field io. That way you simply write $this->io->table() in the commands and you're assured that all commands rely on the same style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's compatible to Symfony's Table class, except for configuration, styling and col/rowspan support.
Sample output comparing master to this PR:
$ php-semver-checker/bin/php-semver-checker compare php-semver-checker2/src php-semver-checker/src
Suggested semantic versioning change: MINOR
Class (MINOR)
[Scanned files] Before: 1, After: 2, Identical: 60
Time: 0.058 seconds, Memory: 7.67 MB
Implements #71