fix: limit nesting depth for encode and decode#317
Open
ckorhonen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxDepthlimit of 1000 for encode, decode, and streaming decodemaxDepththrough the TypeScript API and CLI, withInfinityas an explicit opt-outValidation
nvm exec 24 corepack pnpm run lintnvm exec 24 corepack pnpm run test:typesnvm exec 24 corepack pnpm run testnvm exec 24 corepack pnpm run buildnvm exec 24 corepack pnpm run docs:build/Users/ckorhonen/.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --codex-bin /Applications/Codex.app/Contents/Resources/codexAutoreview result: first run found one accepted P2 issue where decode counted source indentation instead of emitted container depth for tabular row objects and inline keyed containers. Fixed by tracking emitted JSON container depth and adding regressions. Final autoreview rerun was clean with no accepted/actionable findings.