feat!: expand environment variables in config paths and git repos#1806
Open
uwuclxdy wants to merge 3 commits intotopgrade-rs:mainfrom
Open
feat!: expand environment variables in config paths and git repos#1806uwuclxdy wants to merge 3 commits intotopgrade-rs:mainfrom
uwuclxdy wants to merge 3 commits intotopgrade-rs:mainfrom
Conversation
GideonBear
requested changes
Mar 1, 2026
GideonBear
changed the title
shellexpand::tilde() with shellexpand::full() to support environment variables in config pathsshellexpand::tilde() with shellexpand::full() to support environment variables in config paths
GideonBear
changed the title
shellexpand::tilde() with shellexpand::full() to support environment variables in config paths
Member
|
This is technically a breaking change ( |
GideonBear
changed the title
Member
|
The release notes should mention the migration path, which is replacing |
GideonBear
reviewed
Mar 1, 2026
barkleesanders
added a commit
to barkleesanders/topgrade
that referenced
this pull request
Mar 8, 2026
From PR topgrade-rs#1806 by uwuclxdy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Replaces
shellexpand::tilde()withshellexpand::full()as discussed in #921.Closes #921.
Standards checklist
CONTRIBUTING.md