Fully update AVB hash header to match repacked contents. - #9831
Draft
kousu wants to merge 2 commits into
Draft
Conversation
Author
|
To see the effect of this, use this script: examine_avb.py Stockdigest match: True Beforedigest match: False Afterdigest match: True |
kousu
force-pushed
the
repack-avb-header
branch
from
April 27, 2026 08:08
5922503 to
2c11dd4
Compare
Fixes topjohnwu#8389 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This follows topjohnwu#9830 by recomputing the AVB hash. Apparently few (no?) devices actually respect this hash in the wild at the moment, but it's good to be prepared. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kousu
force-pushed
the
repack-avb-header
branch
from
April 28, 2026 01:56
2c11dd4 to
c736c8b
Compare
Collaborator
|
I might be mistaken since it's been awhile, but IIRC part of the reason the headers/footers were hacked and not updated was to appear (at least in passing) as though the partition was unmodified. Perhaps that's proven pointless now though, given the recent issue your other PR fixed, but thought I'd mention it. |
Author
|
No, really, thank you for mentioning that. This works on my phone but I am very aware that bootloaders are touchy and this could backfire on other devices. If there is experience from live devices that should trump the written specs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows (=> is drafted until) #9830 by adding the full recompution of the AVB hash.
Apparently few (no?) devices actually respect this hash in the wild at the moment, but it is good to be prepared!