Skip to content

feat: Added firebase tools to ios pipeline#204

Merged
nfebe merged 1 commit into
devfrom
fix/firebase-tools
Jun 9, 2026
Merged

feat: Added firebase tools to ios pipeline#204
nfebe merged 1 commit into
devfrom
fix/firebase-tools

Conversation

@austin047

Copy link
Copy Markdown
Collaborator

Description

Added Firebase tools to fix the iOS pipeline issue

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@austin047 austin047 self-assigned this Jun 9, 2026
@austin047 austin047 marked this pull request as ready for review June 9, 2026 20:28
@sourceant

sourceant Bot commented Jun 9, 2026

Copy link
Copy Markdown

Code Review Summary

The PR adds necessary Firebase and FlutterFire CLI tools to the iOS pipeline to resolve distribution issues.

🚀 Key Improvements

  • Ensures firebase-tools and flutterfire_cli are available in the CI environment.
  • Correctly updates the $GITHUB_PATH so the Dart pub cache binaries are accessible.

💡 Minor Suggestions

  • Consider pinning the version of firebase-tools to avoid breaking changes in the future.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

cache: true

- name: Install Firebase CLI
run: npm install -g firebase-tools

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a best practice to pin the version of CLI tools in CI/CD pipelines to ensure reproducibility and prevent unexpected breakages when new major versions are released.

Suggested change
run: npm install -g firebase-tools
+ run: npm install -g firebase-tools@latest

@austin047 austin047 requested a review from nfebe June 9, 2026 20:29
@nfebe nfebe merged commit 92674de into dev Jun 9, 2026
3 checks passed
@nfebe nfebe deleted the fix/firebase-tools branch June 9, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants