Skip to content

Refactor/remove dead code#206

Merged
austin047 merged 3 commits into
devfrom
refactor/remove-dead-code
Jun 19, 2026
Merged

Refactor/remove dead code#206
austin047 merged 3 commits into
devfrom
refactor/remove-dead-code

Conversation

@austin047

Copy link
Copy Markdown
Collaborator

Description

Removes the death code and includes agent.md to assist with AI code generation

Type of Change

  • [] ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@austin047 austin047 marked this pull request as ready for review June 19, 2026 02:08
@austin047 austin047 requested a review from nfebe June 19, 2026 02:08
@sourceant

sourceant Bot commented Jun 19, 2026

Copy link
Copy Markdown

Code Review Summary

This PR focuses on cleaning up dead code in the budget module, specifically removing remote-fetch logic for budget progress and transactions in favor of a local-first recomputation model. It also adds an AGENTS.md guide to maintain architecture standards.

🚀 Key Improvements

  • Simplified BudgetCubit by removing unused state flags and methods.
  • Eliminated several dead DTOs and UseCases (FetchBudgetProgressUseCase, FetchBudgetTransactionsUseCase).
  • Established a clear 'Architecture Layering Rule' in the new documentation.

💡 Minor Suggestions

  • Remove commented-out code blocks in budget_remote_datasource.dart instead of just commenting them.
  • Verify pubspec.lock version downgrades.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

import 'package:trakli/presentation/utils/app_navigator.dart';
import 'package:trakli/presentation/utils/design_tokens.dart';
import 'package:trakli/presentation/utils/enums.dart';
import 'package:trakli/presentation/utils/dialogs.dart'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import of enums.dart was moved within the import block, but usually, it's better to keep package imports sorted alphabetically and separate from project-relative imports. However, here it's fine, but ensure the enums.dart is actually needed by the remaining code in this file.

Suggested change
import 'package:trakli/presentation/utils/dialogs.dart'
import 'package:trakli/presentation/utils/enums.dart';
import 'package:trakli/presentation/utils/dialogs.dart'
show showDeleteConfirmationDialog, showConfirmationDialog;

@austin047 austin047 merged commit 196763c into dev Jun 19, 2026
3 checks passed
@austin047 austin047 deleted the refactor/remove-dead-code branch June 19, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants