Feat/form-request

[iMercyvlogs]

Use FormRequest in store and update methods in the transactionController

[sourceant]

Code Review Summary

This PR successfully refactors the TransactionController to use FormRequest classes for store and update operations. This aligns with Laravel best practices and cleans up the controller logic.

🚀 Key Improvements

• Extracted validation logic into StoreTransactionRequest and UpdateTransactionRequest.
• Created a base ApiFormRequest to standardize JSON error responses for validation failures.
• Updated multiple import-related requests to extend the new base class.

💡 Minor Suggestions

• Remove commented-out code in the header of all updated Request files.
• Standardize boolean checks in required_if validation rules.

[sourceant]

Review complete. See the overview comment for a summary.

[sourceant]

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

[github-actions]

Coverage Report
PR coverage: 72.09%
Baseline: 72.04%
Change: ✅+0%

[nfebe]

Pull request title not properly named, seems to have is_myself changes leaking in.

[nfebe]

@iMercyvlogs the pull request title does not follow the patterns we use

[kofimokome]

This is good. However, failure responses have a structure. See

$this->failure()

It should be such that If the form request validation fails, the response structure should follow the same structure as $this->failure()