Conversation
svn path=/src/branches/virtaal-0.7/; revision=17826
… fixes the issue of the suggestions showing just after a file is closed. svn path=/src/branches/virtaal-0.7/; revision=17828
svn path=/src/branches/virtaal-0.7/; revision=17905
svn path=/src/branches/virtaal-0.7/; revision=17933
svn path=/src/branches/virtaal-0.7/; revision=17935
svn path=/src/branches/virtaal-0.7/; revision=17937
svn path=/src/branches/virtaal-0.7/; revision=17951
svn path=/src/branches/virtaal-0.7/; revision=17952
svn path=/src/branches/virtaal-0.7/; revision=17957
svn path=/src/branches/virtaal-0.7/; revision=17959
svn path=/src/branches/virtaal-0.7/; revision=17962
svn path=/src/branches/virtaal-0.7/; revision=17964
svn path=/src/branches/virtaal-0.7/; revision=17965
svn path=/src/branches/virtaal-0.7/; revision=17970
svn path=/src/branches/virtaal-0.7/; revision=17972
…ed. This avoids a slight flickering of the title bar. svn path=/src/branches/virtaal-0.7/; revision=17974
svn path=/src/branches/virtaal-0.7/; revision=17977
svn path=/src/branches/virtaal-0.7/; revision=17988
svn path=/src/branches/virtaal-0.7/; revision=17992
…the moment. svn path=/src/branches/virtaal-0.7/; revision=18018
svn path=/src/branches/virtaal-0.7/; revision=18052
svn path=/src/branches/virtaal-0.7/; revision=18053
Thanks also to Alexander Dupuy for review and helping to get the file ready for commit.
Member
|
Thanks for this, but closing after review - it doesn't add any new translation coverage (checked directly: none of the currently-untranslated strings in po/es.po are covered here). The differences it does have from current es.po are wording/style choices on already-translated strings (capitalization, imperative vs. infinitive verb form, plus one genuine typography improvement) - not something to import wholesale without a Spanish speaker's judgment call on each one. Happy to reconsider individual changes if there's a case for them. |
dwaynebailey
pushed a commit
to dwaynebailey/virtaal
that referenced
this pull request
Sep 2, 2026
… of the file Friedel Wolff wrote this string correctly in 2011 (2933ab8, imported from the old SVN history); it had drifted to plain quotes at some later point, inconsistent with the 18 other « » uses already in this same file. Found while reviewing translate#3322 (cyphra) - that PR happens to still carry this original wording since its branch never touched the line, but the credit belongs with the original 2011 translation, not that PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dwaynebailey
pushed a commit
to dwaynebailey/virtaal
that referenced
this pull request
Sep 2, 2026
… of the file Friedel Wolff wrote this string correctly in 2011 (2933ab8, imported from the old SVN history); it had drifted to plain quotes at some later point, inconsistent with the 18 other « » uses already in this same file. Found while reviewing translate#3322 (cyphra) - that PR happens to still carry this original wording since its branch never touched the line, but the credit belongs with the original 2011 translation, not that PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dwaynebailey
pushed a commit
that referenced
this pull request
Sep 2, 2026
… of the file Friedel Wolff wrote this string correctly in 2011 (2933ab8, imported from the old SVN history); it had drifted to plain quotes at some later point, inconsistent with the 18 other « » uses already in this same file. Found while reviewing #3322 (cyphra) - that PR happens to still carry this original wording since its branch never touched the line, but the credit belongs with the original 2011 translation, not that PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtaal-0_7.es.po.gz