Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb650d11b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| when Transloadit::Step then steps.to_hash | ||
| else | ||
| if steps.uniq(&:name) != steps | ||
| if steps.uniq != steps |
There was a problem hiding this comment.
steps.uniq != steps only detects fully equal elements, so it misses the duplicate-name case this guard is meant to catch (e.g., two hashes keyed by :thumbs with different robot options, or two Step objects with the same name). In those cases no ArgumentError is raised and steps.inject({}) { |h, s| h.update s } silently overwrites the earlier step, changing assembly instructions compared to previous behavior.
Useful? React with 👍 / 👎.
1 participant
Hello,
#50 this pull request breaks the support for
Array<Hash>support for steps which we came across while trying to upgrade from v2 -> v3.