refactor: change Node pointers to values & return (Node, bool) - #21
refactor: change Node pointers to values & return (Node, bool)#21topi314 wants to merge 1 commit into
Conversation
b4b762c to
0e66c09
Compare
839edd6 to
f22ab79
Compare
|
any chance you have some time to look at this? @amaanq |
|
Sorry @topi314, I think after thinking about this for a bit, it makes total sense to have the node methods pass the object by value, since none of them besides Edit mutate the Node, and they're pretty small, stack-allocated objects - with that, I would think it'd be more natural if |
|
hey @amaanq, thanks for reconsidering on this matter. Yes I'd love to implement this and will try to do it in the next days. |
f22ab79 to
d7ee56b
Compare
d7ee56b to
24f70e3
Compare
|
I think this should be all changes required for refactoring. I don't particularly like how I've written the tests, but this is prob the best we can do. |
|
@amaanq any chance you got some time to spare on this? |
This changes the method receivers of the
Nodetype to values instead of pointers for non mutating methods & pointer return type as discussed in #19 (comment)