Fix missing tree_sitter/parser.h in Python sdist - #63
Open
vegaoqiang wants to merge 1 commit into
Open
Conversation
Fix missing parser.h in Python sdist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Python source builds failing due to a missing generated header file in the published sdist.
Currently, pip install --no-binary=:all: tree-sitter-json fails with:
The issue is that src/tree_sitter/parser.h is not included in the PyPI sdist.
This problem is mostly hidden on x86_64/aarch64 because prebuilt wheels are available, but it breaks installation on platforms without wheels such as ppc64le.
This PR adds a MANIFEST.in to ensure generated headers and source files are included in the sdist.