More fuzzer fixes - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more issues found by ocamlgrammarfuzzer.
Indexing operators
The
.inX.%(0)should be part of the indexing operator token.%. OtherwiseX.will be parsed as the start of a module path, and then fail on the%. This is a minor fix, since the type checker will never accept an indexing operator on a module, but syntactically it's valid.Block access types
OxCaml only supports the block access types
idx_immandidx_mut, but the grammar allows arbitrary identifiers.Module strengthening
Module strengthening can't be combined with other module type constraints. In
module rec M : S with M and type t = tis invalid, butmodule rec M : S with M and M : Sshould be allowed.