Fix building DALI with TRITON_DALI_SKIP_DOWNLOAD=ON#222
Draft
szalpal wants to merge 3 commits into
Draft
Conversation
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Collaborator
|
CI MESSAGE: [10619632]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [10619632]: BUILD FAILED |
jantonguirao
approved these changes
Nov 7, 2023
Collaborator
|
CI MESSAGE: [39441680]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [39441680]: BUILD FAILED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for building DALI Backend directly within Triton container with
-D TRITON_SKIP_DALI_DOWNLOAD=ONoption passed to the cmake.When the aforementioned option is passed to
cmake,get_dali_pathsfunction is responsible for discovering the path of the DALI installation in the system. This function uses DALI and Python directly. In case of building within Triton container, the system-definedpythonpath is not the proper one. The properpythonpath is the one created by the conda environment, which has a different path than the system-definedpythonbinary. This PR allows to specify whichpythonshould be used insideget_dali_pathsinvocation.From now on, when DALI is built within Triton docker container,
TRITON_DALI_BUILD_IN_TRITONoption shall be turnedON(it is not the default option).