This repository was archived by the owner on Feb 3, 2026. It is now read-only.
Bugfix: Unsubscribe from Redux store when component is unmounted#71
Open
taueres wants to merge 2 commits into
Open
Bugfix: Unsubscribe from Redux store when component is unmounted#71taueres wants to merge 2 commits into
taueres wants to merge 2 commits into
Conversation
Contributor
|
Is this PR still needed or can we close it? I saw there is another one with the exact same name #73, which one of the two is the one we want to merge eventually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectwas not correctly unsubscribing from the Redux store whencomponentWillUnmountwas triggered in thechildInstance.I'm now forwarding the event
componentWillUnmountto theWrapperComponentso that the cleanup is performed as expected.