Skip to content

Comments

UBI10 for 2.3#567

Open
desmax74 wants to merge 3 commits intotrustification:release/1.1.zfrom
desmax74:ubi10
Open

UBI10 for 2.3#567
desmax74 wants to merge 3 commits intotrustification:release/1.1.zfrom
desmax74:ubi10

Conversation

@desmax74
Copy link
Collaborator

@desmax74 desmax74 commented Feb 9, 2026

Summary by Sourcery

Update container images and metadata to target UBI 10.

Build:

  • Switch operator and test container base images from UBI 9 minimal to UBI 10 minimal.
  • Update bundle CPE label to reference the UBI 10 (el10) platform.

Signed-off-by: desmax74 <mdessi@redhat.com>
Signed-off-by: desmax74 <mdessi@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates container base images and metadata from UBI9/EL9 to UBI10/EL10 for the operator image and its test harness, keeping the rest of the build and chart logic unchanged.

File-Level Changes

Change Details Files
Update the test pod image in the Helm chart to use UBI10 instead of UBI9.
  • Change the Kubernetes test container image reference from ubi9/ubi-minimal:latest to ubi10/ubi-minimal:latest
  • Preserve existing test command, args, and pod spec semantics
helm-charts/redhat-trusted-profile-analyzer/templates/tests/test-server-connection.yaml
Update the main operator container base image to UBI10.
  • Change the Dockerfile base image from ubi9/ubi-minimal:latest to ubi10/ubi-minimal:latest
  • Keep Go build and runtime configuration unchanged
Dockerfile
Adjust bundle metadata CPE to target EL10 instead of EL9.
  • Change CPE label from el9 to el10 in the bundle Dockerfile while keeping product and version the same
bundle.Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The CPE label in bundle.Dockerfile still references trusted_profile_analyzer:2.2; verify that this matches the intended 2.3 release and update if necessary to keep metadata consistent.
  • Both the main Dockerfile and the test pod use ubi-minimal:latest; consider pinning to a specific UBI10 tag to ensure reproducible builds and avoid unexpected base image changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The CPE label in `bundle.Dockerfile` still references `trusted_profile_analyzer:2.2`; verify that this matches the intended 2.3 release and update if necessary to keep metadata consistent.
- Both the main Dockerfile and the test pod use `ubi-minimal:latest`; consider pinning to a specific UBI10 tag to ensure reproducible builds and avoid unexpected base image changes.

## Individual Comments

### Comment 1
<location> `Dockerfile:29` </location>
<code_context>
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM registry.access.redhat.com/ubi9/ubi-minimal:latest
+FROM registry.access.redhat.com/ubi10/ubi-minimal:latest

 LABEL com.redhat.component="rhtpa-operator"
</code_context>

<issue_to_address>
**suggestion:** Consider pinning the UBI base image to a specific version or digest instead of using `latest`.

`:latest` makes builds non-reproducible and can change behavior whenever Red Hat updates `ubi10/ubi-minimal`. Pinning to a specific minor version or digest keeps builds deterministic and simplifies debugging regressions.

Suggested implementation:

```
# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
# Pin UBI base image to a specific version for reproducible builds
FROM registry.access.redhat.com/ubi10/ubi-minimal:10.0-XXXX

```

1. Replace `10.0-XXXX` with a real, vetted tag that exists in `registry.access.redhat.com/ubi10/ubi-minimal` (for example, something like `10.0-1234`), or replace the whole reference with a `@sha256:<digest>` if you prefer digest pinning.
2. Update any build or security documentation to mention the chosen UBI version/digest and the process for bumping it (e.g., on security updates).
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
FROM registry.access.redhat.com/ubi9/ubi-minimal:latest
FROM registry.access.redhat.com/ubi10/ubi-minimal:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider pinning the UBI base image to a specific version or digest instead of using latest.

:latest makes builds non-reproducible and can change behavior whenever Red Hat updates ubi10/ubi-minimal. Pinning to a specific minor version or digest keeps builds deterministic and simplifies debugging regressions.

Suggested implementation:

# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
# Pin UBI base image to a specific version for reproducible builds
FROM registry.access.redhat.com/ubi10/ubi-minimal:10.0-XXXX

  1. Replace 10.0-XXXX with a real, vetted tag that exists in registry.access.redhat.com/ubi10/ubi-minimal (for example, something like 10.0-1234), or replace the whole reference with a @sha256:<digest> if you prefer digest pinning.
  2. Update any build or security documentation to mention the chosen UBI version/digest and the process for bumping it (e.g., on security updates).

Signed-off-by: desmax74 <mdessi@redhat.com>
@desmax74
Copy link
Collaborator Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant