Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates container base images and metadata from UBI9/EL9 to UBI10/EL10 for the operator image and its test harness, keeping the rest of the build and chart logic unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The CPE label in
bundle.Dockerfilestill referencestrusted_profile_analyzer:2.2; verify that this matches the intended 2.3 release and update if necessary to keep metadata consistent. - Both the main Dockerfile and the test pod use
ubi-minimal:latest; consider pinning to a specific UBI10 tag to ensure reproducible builds and avoid unexpected base image changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The CPE label in `bundle.Dockerfile` still references `trusted_profile_analyzer:2.2`; verify that this matches the intended 2.3 release and update if necessary to keep metadata consistent.
- Both the main Dockerfile and the test pod use `ubi-minimal:latest`; consider pinning to a specific UBI10 tag to ensure reproducible builds and avoid unexpected base image changes.
## Individual Comments
### Comment 1
<location> `Dockerfile:29` </location>
<code_context>
# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM registry.access.redhat.com/ubi9/ubi-minimal:latest
+FROM registry.access.redhat.com/ubi10/ubi-minimal:latest
LABEL com.redhat.component="rhtpa-operator"
</code_context>
<issue_to_address>
**suggestion:** Consider pinning the UBI base image to a specific version or digest instead of using `latest`.
`:latest` makes builds non-reproducible and can change behavior whenever Red Hat updates `ubi10/ubi-minimal`. Pinning to a specific minor version or digest keeps builds deterministic and simplifies debugging regressions.
Suggested implementation:
```
# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
# Pin UBI base image to a specific version for reproducible builds
FROM registry.access.redhat.com/ubi10/ubi-minimal:10.0-XXXX
```
1. Replace `10.0-XXXX` with a real, vetted tag that exists in `registry.access.redhat.com/ubi10/ubi-minimal` (for example, something like `10.0-1234`), or replace the whole reference with a `@sha256:<digest>` if you prefer digest pinning.
2. Update any build or security documentation to mention the chosen UBI version/digest and the process for bumping it (e.g., on security updates).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM registry.access.redhat.com/ubi9/ubi-minimal:latest | ||
| FROM registry.access.redhat.com/ubi10/ubi-minimal:latest |
There was a problem hiding this comment.
suggestion: Consider pinning the UBI base image to a specific version or digest instead of using latest.
:latest makes builds non-reproducible and can change behavior whenever Red Hat updates ubi10/ubi-minimal. Pinning to a specific minor version or digest keeps builds deterministic and simplifies debugging regressions.
Suggested implementation:
# Use distroless as minimal base image to package the manager binary
# Refer to https://github.com/GoogleContainerTools/distroless for more details
# Pin UBI base image to a specific version for reproducible builds
FROM registry.access.redhat.com/ubi10/ubi-minimal:10.0-XXXX
- Replace
10.0-XXXXwith a real, vetted tag that exists inregistry.access.redhat.com/ubi10/ubi-minimal(for example, something like10.0-1234), or replace the whole reference with a@sha256:<digest>if you prefer digest pinning. - Update any build or security documentation to mention the chosen UBI version/digest and the process for bumping it (e.g., on security updates).
Signed-off-by: desmax74 <mdessi@redhat.com>
Collaborator
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update container images and metadata to target UBI 10.
Build: