Add Maven Central (Sonatype) publishing support for Android#4689
Open
0xh3rman wants to merge 2 commits intotrustwallet:masterfrom
Open
Add Maven Central (Sonatype) publishing support for Android#46890xh3rman wants to merge 2 commits intotrustwallet:masterfrom
0xh3rman wants to merge 2 commits intotrustwallet:masterfrom
Conversation
Contributor
Author
|
@sergei-boiko-trustwallet could you please take a look and approve CI? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Sonatype (Maven Central) as a publish target for Android artifacts, inspired by #4641
Closes #4612 (Javadoc for Android artifacts)
Closes #4613 (POM metadata)
Closes #4614 (Artifact signing)
Why we need this
Changes
gradle-nexus-publish-plugintoandroid/build.gradlewith Sonatype Central configwallet-coreandwallet-core-protowallet-coreandwallet-core-proto(required by Maven Central)--targetflag totools/android-releasefor testing individual targets (local,sonatype,gpr,all)Usage
Setup
Before publishing to Sonatype:
-
SONATYPE_USERNAME/SONATYPE_PASSWORD— Generate a token-
MVN_SIGNING_KEY/MVN_SIGNING_PASSPHRASE— Set up GPG signingNotes
Sonatype publishing could not be fully tested locally (requires credentials), but follows the same
pattern used to publish Gemstone to Maven Central: https://central.sonatype.com/artifact/com.gemwallet.gemstone/gemstone, there is no public release workflows in wallet core, so we only updated the script
Test
tools/android-release 0.0.1-test --target local# verify Gradle config compiles and artifacts appearin ~/.m2
@sergei-boiko-trustwallet @10gic @alex-kobozev-tw could you guys take a look?
Thanks