fix(aes): Fix AESParameters deserialization for AES-128-CBC and improve error handling for unsupported ciphers

[sergei-boiko-trustwallet]

This pull request refactors the getCipher function in AESParameters.cpp to improve error handling and add support for an additional cipher. The most important changes include switching from chained else if statements to separate if blocks, adding support for the gAes128Cbc cipher, and throwing an exception for unsupported ciphers instead of defaulting.

Cipher support and error handling improvements:

• Added support for the gAes128Cbc cipher in the getCipher function.
• Changed error handling to throw a std::invalid_argument exception with a descriptive message when an unsupported cipher is provided, instead of defaulting to TWStoredKeyEncryptionAes128Ctr.

Code style refactoring:

• Replaced chained else if statements with individual if statements for clarity and maintainability in the getCipher function.

[Copilot]

Pull request overview

Refactors keystore AES cipher selection to recognize AES-128-CBC and to fail fast with a descriptive error when an unknown cipher string is encountered, instead of silently defaulting to AES-128-CTR.

Changes:

• Added aes-128-cbc handling in getCipher().
• Replaced the previous default-to-CTR behavior with a thrown std::invalid_argument for unsupported ciphers.
• Refactored the conditional structure in getCipher() for readability.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Binary size comparison

➡️ aarch64-apple-ios: 14.34 MB

➡️ aarch64-apple-ios-sim: 14.34 MB

➡️ aarch64-linux-android: 18.77 MB

➡️ armv7-linux-androideabi: 16.20 MB

➡️ wasm32-unknown-emscripten: 13.68 MB