Fix courtyards for jst, sot, to220, vson, electrolytic#590
Merged
MustafaMulla29 merged 9 commits intomainfrom Apr 8, 2026
Merged
Fix courtyards for jst, sot, to220, vson, electrolytic#590MustafaMulla29 merged 9 commits intomainfrom
MustafaMulla29 merged 9 commits intomainfrom
Conversation
MustafaMulla29
changed the title
MustafaMulla29
changed the title
seveibar
reviewed
Apr 8, 2026
seveibar
reviewed
Apr 8, 2026
src/fn/vson.ts
Outdated
| const courtyard: PcbCourtyardRect = { | ||
| type: "pcb_courtyard_rect", | ||
| pcb_courtyard_rect_id: "", | ||
| const roundToCourtyardGrid = (value: number) => |
Contributor
There was a problem hiding this comment.
This function doesnt make sense. What is a courtyard grid? I should have said something earlier but there is no suvh thing as a courtyard grid. You could say roundTo10um but why are we rounding anyway?
seveibar
approved these changes
Apr 8, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
See comments.
We never use inline closures, i keep seeing them in your code! They are an antipattern and prevent refactoring code because they steal scope!
…nt-courtyards # Conflicts: # src/fn/ssop.ts
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.