feat: unify importer and scrobbler APIs under a single app#6
feat: unify importer and scrobbler APIs under a single app#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| raise ValueError("updates must contain at least one entry") | ||
| return value | ||
|
|
||
|
|
||
| importer_router = APIRouter(prefix="/importer", tags=["importer"]) | ||
|
|
||
|
|
||
| def ensure_yt_dlp_is_updated() -> None: |
There was a problem hiding this comment.
Move importer API under new prefix without updating frontend defaults
The new router now mounts every importer endpoint and WebSocket under /importer (APIRouter(prefix="/importer")). The Svelte dashboard that ships in modules/importer/frontend still defaults VITE_API_BASE to /api and constructs the WebSocket URL as /ws/jobs, so a stock build will keep calling the old paths and receive 404s. Unless every deployment sets a custom VITE_API_BASE at build time, the importer UI can no longer reach the backend. Consider either exposing the routes under both prefixes for compatibility or updating the frontend defaults to /importer/api and /importer/ws/jobs in the same change.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task