add update or replace to sim and fix update or replace ordering#5606
Open
Pavan-Nambi wants to merge 5 commits intotursodatabase:mainfrom
Open
add update or replace to sim and fix update or replace ordering#5606Pavan-Nambi wants to merge 5 commits intotursodatabase:mainfrom
Pavan-Nambi wants to merge 5 commits intotursodatabase:mainfrom
Conversation
9174863 to
2515580
Compare
Pavan-Nambi
commented
Feb 25, 2026
| - Three similar lines > premature abstraction | ||
|
|
||
| ## Index Mutations | ||
|
|
Contributor
Author
There was a problem hiding this comment.
if any of u think, this pollutes code-qualit/skill.md i am ok with removing it, personally i only added this cuz i remember seeing similar issue in check constraints pr - see #5040 (comment) and it's easy to miss. i think it's nice to have this.
Merging this PR will not alter performance
Comparing Footnotes
|
…lved to codequality skill
8cf77f2 to
b5c5122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this do not qualify for turso challenge, this is a general simulator improvement. - update or replace is added after 0.4.4In update or replace , we handled the rowid conflict too late; we updated indexes first, then deleted the conflicting row. If the new row and the conflicting row shared
indexed values, this could leave stale entries in secondary indexes (and NotExists could also move the table cursor onto the wrong row). Fix: delete the conflicting row (and its index
entries) before the index update loop, then re-seek back to the row being updated.