Preserve column type size spacing in sqlite_schema SQL#5668
Open
kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
Open
Preserve column type size spacing in sqlite_schema SQL#5668kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
Conversation
kumarUjjawal
requested review from
jussisaurio,
penberg and
pereman2
as code owners
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
sqlite_schema.sqlnormalization for column type declarations with size parameters.Specifically, it preserves original spacing/comments/newlines between the type name and size parentheses when storing
CREATE TABLESQL, so declarations like:varchar ( 255)varchar( 255)remain distinct in
sqlite_schema.sql, matching SQLite behavior.Motivation and context
Issue #3264 reported a compatibility mismatch: Turso normalized both declarations above to the same output (
varchar (255)), while SQLite preserves original spacing insqlite_schema.Closes #3264
Description of AI Usage