Resolve TableCall names as functions and preserve nested json_each args#5696
Draft
kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
Draft
Resolve TableCall names as functions and preserve nested json_each args#5696kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
kumarUjjawal wants to merge 2 commits intotursodatabase:mainfrom
Conversation
sivukhin
reviewed
Mar 5, 2026
Collaborator
sivukhin
left a comment
There was a problem hiding this comment.
@jussisaurio , what do you think if we will have separate translation methods for TableCall case? Seems like it is pretty special case and instead of rejecting all things handled in the generic parse_table method we can just implement small parse_table_call method instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect
TableCallresolution in the planner that caused nested table-valued function calls (notablyjson_each) to lose their arguments in subqueries.Changes made:
SelectTable::TableCallis treated as a function call path, not as a normal table/CTE reference path.name(...):'<name>' is not a function, matching SQLite behavior.FROM cte) unchanged.Motivation and context
Issue #5157 reported SQLite compatibility breakage where nested
json_eachreturned empty results after anotherjson_eachhad executed.Closes #5157
Description of AI Usage