Conversation
|
I'm concerned about the duplication in SendRequest/SendRequestWithContext - it might be better to have SendRequest just call SendRequestWithContext with a context.Background(), and then that way you only have one version of the code. |
| } | ||
|
|
||
| func GetNext(baseUrl string, response interface{}, getNextPage func(nextPageUri string) (interface{}, error)) (interface{}, error) { | ||
| func GetNextWithContext(ctx context.Context, baseUrl string, response interface{}, getNextPage func(ctx context.Context, nextPageUri string) (interface{}, error)) (interface{}, error) { |
There was a problem hiding this comment.
I think we need to add this as a second method, similar to the SendRequestWithContext, otherwise we're going to break everyone's clients.
|
Hi there, I was really excited to see progress being made on adding Context support to twilio-go, but it looks like this pull request has lost momentum. Is the Twilio team still pursuing this? Do y'all have an ETA? If it's not on the short-term roadmap, would you be open to reviewing a new PR? I think I mostly understand how twilio-go and twilio-oai-generator rely on each other. Thanks so much, Matt Light |
Hi @lightster, |
3 participants
Fixes
Introduce Context
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.