fix: Bug serialising TwiML Voice Prompt verb's for attribute#299
Open
settermjd wants to merge 1 commit intotwilio:mainfrom
Open
fix: Bug serialising TwiML Voice Prompt verb's for attribute#299settermjd wants to merge 1 commit intotwilio:mainfrom
settermjd wants to merge 1 commit intotwilio:mainfrom
Conversation
The original Prompt tag's attribute mapping resulted in the "for" attribute being serialised incorrectly as "for_". According to the Voice Prompt documentation this is incorrect. It must be serialised as "for". This change corrects the serialisation of the verb to correctly serialise the attribute. Resolves: twilio#298 Signed-off-by: Matthew Setter <matthew@matthewsetter.com>
settermjd
changed the title
Author
|
I've not added inline documentation to the code I modified, as there didn't seem to be value in doing so. However, if this is incorrect, please let me know. I'm more than happy to do so if need be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Prompt tag's attribute mapping resulted in the "for" attribute being serialised incorrectly as "for_". According to the Voice Prompt documentation this is incorrect. It must be serialised as "for".
This change corrects the serialisation of the verb to correctly serialise the attribute.
Resolves: #298
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.