Conversation
Contributor
|
One thing I'm working on is seeing if any of the classes that are mostly scala re-writes of parquet classes can either use the original parquet classes, or even better be skipped entirely. Parts of Parquet's class hierarchy can be pretty confusing, I'd rather not mirror that all over again here, especially the classes with non trivial code in them (which have tests in parquet but not here). So for the stuff we need to keep, I'm also working on adding some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs some more work before merging around cleaning it up, more benchmarks and seeing what does/doesn't need to be in lui.
TBD are real world tests against jobs with manual projection.