Open
Conversation
Contributor
Author
Contributor
It's a non-starter for us. It won't be installed on the Typst web app for example. icu4x1 is an alternative. However, there are concerns about the size of the collation data it pulls, and how this could impact the size of e.g. the Typst binary, Typst on the web app etc. One alternative that was considered is to delegate this job to a trait which implements localized sorting and let upstream users (i.e. Typst) handle it. We're not fully decided on this, but it's at least better than the status quo. Footnotes |
Contributor
Author
|
For now I switched to icu4x. Let me know if the typst team wants another solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Hayagriva did not compare UTF-8 strings correctly #193. This is due to how Rust compares UTF-8 Strings. This PR addresses the issue by using
icu_ucolfor comparison, using the current locale.Fixes #193 and adds one test to citeproc-pass.
Adds
rust_icu_ucolas a dependency. Problem: icu must be installed on the user's system. How do we handle this?I might have missed some comparison in
csl_cmp.