Open
Conversation
PgBiel
reviewed
Dec 28, 2025
| ); | ||
| } | ||
| } else if has_et_al { | ||
| } else if ctx.instance.sorting.is_none() && has_et_al { |
Contributor
There was a problem hiding this comment.
There are other checks for has_et_al above. Are we sure we only have to change this step?
I suppose that there could be a bit of a debate on whether changing the sort behavior too much would be welcome as well. In principle, it seems like the user would find it unexpected for sort to not sort based on the final text, which includes et al. But at least your argument seems reasonable.
Overall, maybe my question is how much do we want to modify the sort to ignore et al.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not part of the CSL spec but is part of the test suite. It also makes sense.
If you have two items and sort with a name macro with
names-use-first="1"then you get, e.g., "Smith" and "Smith et al." if you render the "et al.". However, then the second is always greater than the first, whereas you want them to be equal and further sort keys to decide which is first.Makes 1 test pass.