Fix parsing of atypical page numbers and serial numbers#445
Open
YDX-2147483647 wants to merge 3 commits intotypst:mainfrom
Open
Fix parsing of atypical page numbers and serial numbers#445YDX-2147483647 wants to merge 3 commits intotypst:mainfrom
YDX-2147483647 wants to merge 3 commits intotypst:mainfrom
Conversation
20eebeb to
15c9f4c
Compare
beba1db to
29c2d6e
Compare
YDX-2147483647
commented
Jan 14, 2026
| #[test] | ||
| fn nonnumeric_page() { | ||
| // https://github.com/typst/hayagriva/issues/170 | ||
| for s in &["11E201", "1.36"] { |
Contributor
Author
There was a problem hiding this comment.
CSL spec says nothing about 1.36, and citeproc-js (citext) thinks it's non-numeric.
Test code
#import "@local/citext:0.3.0": *
#let source = ```bib
@book{a,
title = {A},
pages = {1a},
}
@book{b,
title = {B},
pages = {1.36},
}
```.text
#let csl = ```xml
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" name-as-sort-order="all" sort-separator=" " demote-non-dropping-particle="never" initialize-with=" " initialize-with-hyphen="false" page-range-format="expanded" default-locale="zh-CN">
<info>
<id />
<title />
<updated>2009-08-10T04:49:00+09:00</updated>
</info>
<citation>
<layout/>
</citation>
<bibliography>
<layout delimiter="; ">
<group delimiter=" ">
<text variable="title"/>
<text variable="page"/>
<choose>
<if is-numeric="page">
<text value="(is-numeric)"/>
</if>
<else>
<text value="(non-numeric)"/>
</else>
</choose>
</group>
</layout>
</bibliography>
</style>
```.text
#let bib = init-citation(source, mode: "stable", csl: csl)
#show: show-extcite.with(bib: bib, gen-id: true)
- @a
- @b
#show bibliography: none
#bibliography(bytes(source))
#extbib(bib)
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric::from_strrefuse to parse irregular page numbers like11E720, so that they can be interpreted as non-numeric strings.Numericstore leading zeros (e.g.,011) and whitespaces between affixes and numbers (e.g.,GB/T 7714) inprefix.<if is-numeric="page">. Previously, it's always false.Resolves #170
Resolves #440 (which is a part of #312)
Also relates to #327 because
number_{LeadingZeros,MixedText}now pass.Notes for Chinese:
This PR eliminates
num,code_space, andhan_spaceerrors. According to the survey Hayagriva对GB/T 7714—2015的支持情况, they account for 41% of the errors in GB/T 7714—2015.