Skip to content

Add -embed flag into mockgen#171

Open
lance6716 wants to merge 7 commits intouber-go:mainfrom
lance6716:proposal_embed_option
Open

Add -embed flag into mockgen#171
lance6716 wants to merge 7 commits intouber-go:mainfrom
lance6716:proposal_embed_option

Conversation

@lance6716
Copy link
Copy Markdown

@lance6716 lance6716 commented Mar 28, 2024

close #64

this PR is ported from golang/mock#683

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

…tion

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]Proposal embed option Add -embed flag into mockgen Mar 28, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Copy Markdown
Author

ping @stoikheia

@lance6716
Copy link
Copy Markdown
Author

PTAL @r-hang

…tion

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Copy Markdown
Author

PTAL @tchung1118 @JacobOaks

@lance6716
Copy link
Copy Markdown
Author

ping @tchung1118 @JacobOaks

@lance6716
Copy link
Copy Markdown
Author

PTAL @tchung1118 @r-hang

@nikzadkhani
Copy link
Copy Markdown

Can a reviewer please review this! I'm interested in this feature

@tommydroptables
Copy link
Copy Markdown

@JacobOaks or @marten-seemann can either of you code review this PR. 🙏 I'm one of many people looking for this feature as part of mockgen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embed original interface into Mock struct

5 participants