Introduce CompiledCGPatterns capturing the TS-Query and regex (placeholder)#527
Merged
ketkarameya merged 4 commits intogh/ketkarameya/25/basefrom Jul 10, 2023
Merged
Conversation
…older) [ghstack-poisoned]
…gex (placeholder)" [ghstack-poisoned]
lazaroclapp
reviewed
Jul 7, 2023
Contributor
lazaroclapp
left a comment
lazaroclapp
left a comment
There was a problem hiding this comment.
Minor documentation nit (also, might be worth having a full documentation comment for both get_match and get_matches)
src/models/capture_group_patterns.rs
Outdated
| } | ||
|
|
||
| impl CompiledCGPattern { | ||
| /// Applies the query upon the given node, and gets all the matches |
Contributor
There was a problem hiding this comment.
Is the documentation correct here? It seems this returns 0 or 1 matches. Is this meant to be the docstring for get_matches?
…gex (placeholder)" Introduces `CompiledCGPattern` which wraps `treesitter::Query` and `regex::Regex` (A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff). ------ [ghstack-poisoned]
…gex (placeholder)" Introduces `CompiledCGPattern` which wraps `treesitter::Query` and `regex::Regex` (A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff). ------ [ghstack-poisoned]
Open
collabrpay
added a commit
to collabrpay/solid-tribble
that referenced
this pull request
Aug 11, 2024
…older) ghstack-source-id: 0ef1c1ae7eaf0b3c2d49a0287818b1b2677b33a0 Pull Request resolved: uber/piranha#527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
CompiledCGPatternwhich wrapstreesitter::Queryandregex::Regex(A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff).
Stack from ghstack (oldest at bottom):