use xdg_data_dirs for desktop files lookup#217
Open
dnk wants to merge 1 commit intoubuntu-mate:masterfrom
Open
use xdg_data_dirs for desktop files lookup#217dnk wants to merge 1 commit intoubuntu-mate:masterfrom
dnk wants to merge 1 commit intoubuntu-mate:masterfrom
Conversation
cwendling
approved these changes
Apr 15, 2025
Contributor
cwendling
left a comment
There was a problem hiding this comment.
Looks good to me, apart that I'd drop the unrelated whitespace changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package managers like "snapd" and "flatpak" registers there applications data directories in XDG environment. so the best way to support them is to use xdg data directories for applications desktop files lookup.
xdg_data_dirs also contain user's applications' desktop files before system ones.
fix for #213, #208