Conversation
|
Can you explain why you choose not to do that in a separate file? I'm interested to know :) |
|
Oh, you can do that in separate files! I didn't know. Actually, I've never used GitHub Actions, so I thought it was supposed to be in the same file as all the other actions. When researching how to trigger an action when a tag is pushed, this if option seemed like the right way to do it. Is it okay to leave it in the same file? I'm not sure if separating both actions is necessary. |
It's not per se BUT it's useful because you get a separate build action instead of having everything in one I'd like to keep it consistent with my other projects which is why I linked a working example : https://github.com/ultrabug/mkdocs-static-i18n/blob/main/.github/workflows/deploy-release.yml Sorry |
|
No worries, i'll make the changes ! |
|
@dalauren still interested in making those changes plz? |
11f7bed to
bca6b11
Compare
|
Hey @ultrabug ! Sorry for the (loooong) delay, it's done, tell me what you think :) |
closes #26