feat: add insample parameter to Diff and Pipeline inverse_transform#3046
Open
TamarAzriel wants to merge 1 commit intounit8co:masterfrom
Open
feat: add insample parameter to Diff and Pipeline inverse_transform#3046TamarAzriel wants to merge 1 commit intounit8co:masterfrom
TamarAzriel wants to merge 1 commit intounit8co:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #3045.
Summary
This PR adds an optional
insampleparameter toinverse_transform()inInvertibleDataTransformerandPipeline.It specifically enables the
Difftransformer to use historical context for accurate inversion.I've also refactored the
Pipelineinverse loop to handle types correctly and update the context iteratively.Other Information
Verified with ~8,100 tests. Added new tests for
Diffintest_diff.py.Unrelated local failures on Windows (Uber hash, Tkinter) are noted but do not affect this PR's logic.
Note to reviewers:
I hope this implementation aligns with the library standards. I'm very open to feedback and would be happy to make any necessary changes or improvements based on your review!