Revert "fix(progressring): ring sizing should respect the ActualSize and Stretch" #22212
+1
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/skia ✏️
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from PR #22186 that addressed ProgressRing sizing with respect to ActualSize and Stretch properties. The revert removes a test case and restores the original SafeEdge calculation in Skia rendering.
Fixes https://github.com/unoplatform/uno/issues/#ISSUE_NUMBER or include a note if this is internal maintenance approved by a team member.
Key Changes
- Removed
When_Stretch_Fillruntime test that validated ProgressRing sizing behavior - Reverted SafeEdge constant from
SK_MaxS32FitsInFloat / 4 - 1back toSK_MaxS32FitsInFloat / 2 - 1in Skia Visual rendering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_ProgressRing.cs | Removes the When_Stretch_Fill test method and cleans up unused imports (Windows.Foundation.Metadata and Uno.UI.RuntimeTests.Helpers) |
| src/Uno.UI.Composition/Composition/Visual.skia.cs | Reverts SafeEdge calculation to original value and removes explanatory comment about clipping bounds issues with LottieVisualSourceBase |
Code Review: The revert itself is clean and complete. However, the PR lacks proper issue linking as required by the Uno Platform contribution guidelines. Please add a reference to the GitHub issue that describes why this revert is needed, or document that this is approved internal maintenance.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22212/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22212/docs/index.html |
Contributor
|
The build 189506 found UI Test snapshots differences: Details
|
Contributor
|
The build 189506 found UI Test snapshots differences: Details
|
Contributor
|
|
ajpinedam
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #22186